Newbie PIC PWM question

"Deep Reset" wrote

wondered if

Have you looked at the output pin with a scope?

including

I don't have a scope, but I lit the adjacent LEDs and varied the duty cycle (CCPR1L) from something like 5 to 95 and could see no difference in brightness between the solid 'on' LEDs and the PWM one. I should've noticed a distinct difference at these sorts of values, I think. I'll see if I can borrow a scope.

Thanks

Deep.

"Deep Reset" wrote

Your code looks ok to me, I don't see any reason for it to not work. I wanted to burn it into a PIC and test it, but I just can't find the time right now. The code below definitely works for me on a 16F628. I get a

256uS period with a duty cycle of 12.5% (32uS) on RB3. The code below was used when I was doing some experimentation, but I ended up needing two PWM pins, so I did it all in software; that's why the ints are disabled, but the comments may indicate otherwise. I left it in the program anyway (for times like this ;-) and it drives an LED directly as a power on indicator and it's quite bright.

BTW, are you sure you aren't being bitten by the watchdog timer and that it's not browning out? You didn't specify what your CONFIG word settings are. You also didn't use any ORG directives to skip over the interrupt vector, so that's a potential issue for later. But it does appear that you have disabled all ints so that really shouldn't be the problem. You could try making PR2 bigger than 100.

; ; Initialize PWM Module ; PWMInit

; Set Period to 255 bsf STATUS, RP0 ; Select BANK 1 bcf PIE1 & 0x07F, TMR2IE ; Turn off TMR2 ints movlw d'255' movwf PR2 & 0x07F bcf STATUS, RP0 ; Select BANK 0

; Set Duty Cycle to 32 movlw DutyCycle movwf CCPR1L

; Setup of Prescaler and TMR2 for different PWM rates (Based on 4Mhz clock) ; (4 Mhz clock) movlw b'00000000' ; TMR2 timer stopped, prescale /1, no post scale ; |||||||+-------------- T2CKPS0 ; ||||||+--------------- T2CKPS1 ; |||||+---------------- TMR2ON ; ||||+----------------- TOUTPS0 ; |||+------------------ TOUTPS1 ; ||+------------------- TOUTPS2 ; |+-------------------- TOUTPS3 ; +--------------------- Unused movwf T2CON

; Set CCP1CON for PWM mode movlw b'00001100' ; PWM Mode ; |||||||+-------------- CCP1M0 ; ||||||+--------------- CCP1M1 ; |||||+---------------- CCP1M2 ; ||||+----------------- CCP1M3 ; |||+------------------ CCP1Y ; ||+------------------- CCP1X ; |+-------------------- Unused ; +--------------------- Unused movwf CCP1CON

; Clear the interrupt flags bcf PIR1, TMR2IF

; Enable Peripheral interrupts bcf INTCON, PEIE

; Enable the timer clrf TMR2 bsf T2CON, TMR2ON ; Start counting

return

Thanks to all who replied/emailed - the code was working all the time - I'd just forgotten two things:

1) Don't trust the eye to measure relative brightness (!) 2) The duty cycle register has an extra 2 bits in CCP1CON.

Thanks again

Deep.